feat(frontends): Implemented numpy fftn with tests #26917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…output dtype to `complex128` as all the ground truth frameworks are returning complex128
|
Thank you for this PR, here is the CI results: This pull request does not result in any additional test failures. Congratulations! |
ivy-leaves
added
the
NumPy Frontend
|
Hi @saeedashrraf there should be a few failing test cases with tensorflow and paddle as the backend which will be resolved once this PR is merged. Please take a look when you have time. Thanks! |
Ishticode
approved these changes
Mar 3, 2024
There was a problem hiding this comment.
Hi @AwkNinja
Thanks for the PR.
This was a good implementation with minor gather related hiccups that I have just fixed. We didn't really need the other PR that you linked. All tests are fixed and passing now. Thank you very much :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Implemented frontend for numpy fftn with tests.
Related Issue
Closes #26585
Checklist
Socials