Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed inconsistent naming of some tests #28028

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

Sai-Suraj-27
Copy link
Contributor

PR Description

For many tests, in the name of the test, there should there be 3 underscores on the left, like test___float__ if the method being tested is float? But i see at many places tests are named like test__float__ with just 2 underscores instead of 3.
https://github.com/unifyai/ivy/blob/82ccaebd9743a6d7d0d47309fc0db3b43c315cbe/ivy_tests/test_ivy/test_frontends/test_paddle/test_tensor/test_tensor.py#L759
This is happening at few places. So, the name of the tests should be fixed.

Related Issue

Closes #28027

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

@ivy-leaves ivy-leaves added JAX Frontend Developing the JAX Frontend, checklist triggered by commenting add_frontend_checklist Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist labels Jan 24, 2024
@vedpatwardhan
Copy link
Contributor

lgtm! Feel free to merge the PR @joaozenobio, thanks @Sai-Suraj-27 😄

@joaozenobio
Copy link
Contributor

Sure! Good work @Sai-Suraj-27 👏

@joaozenobio joaozenobio merged commit 8ff497a into Transpile-AI:main Jan 25, 2024
210 of 685 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JAX Frontend Developing the JAX Frontend, checklist triggered by commenting add_frontend_checklist Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent test names
5 participants