Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed pointwise_ops.torch.real for paddle backend #28115

Merged
merged 10 commits into from
Mar 11, 2024

Conversation

Sai-Suraj-27
Copy link
Contributor

@Sai-Suraj-27 Sai-Suraj-27 commented Jan 30, 2024

PR Description

Fix Frontend Failing Test: tensorflow - pointwise_ops.torch.real

image

Related Issue

Closes #28272

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

Copy link
Contributor

@KareemMAX KareemMAX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we handle the unsupported dtypes gracefully? This is a backend function, so we don't really need to maintain a 1:1 representation with anything.

i.e. we should return true if the dtype is not complex

KareemMAX

This comment was marked as resolved.

Copy link
Contributor

@KareemMAX KareemMAX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is failing:

ivy_tests/test_ivy/test_functional/test_core/test_elementwise.py::test_real,paddle (main: pass)

@joaozenobio joaozenobio removed their assignment Feb 24, 2024
@KareemMAX KareemMAX merged commit 4175957 into Transpile-AI:main Mar 11, 2024
144 of 149 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Frontend Failing Test: tensorflow - pointwise_ops.torch.real
5 participants