Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixed failing docstring tests #28172

Merged
merged 57 commits into from
Feb 7, 2024
Merged

fix: Fixed failing docstring tests #28172

merged 57 commits into from
Feb 7, 2024

Conversation

Sai-Suraj-27
Copy link
Contributor

@Sai-Suraj-27 Sai-Suraj-27 commented Feb 4, 2024 •
edited

PR Description

Fixed failing docstring tests of > 55 functions and updated the skip_temp_list.

The docstring tests workflow is successfully passing for all 4 backends.

image

Related Issue

Closes #28135
Closes #28167

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

@Sai-Suraj-27
Fixed failing of test_docstrings.yml.
e19e17b
@Sai-Suraj-27
Fixed docstrings tests for argmax function.
41e428d
@Sai-Suraj-27
Fixed docstrings tests for split function.
03660cd
@Sai-Suraj-27
Fixed ivy.manipulation docstring failures.
9ab4ef3
@Sai-Suraj-27
Fixed ivy.outer failing doc strings for jax,numpy,tf backends.
0570559
@Sai-Suraj-27
Passed arguments correctly for ivy.pool examples.
bc2f158
@Sai-Suraj-27
Fixed cosh failing docstrings.
0d0d10e
@Sai-Suraj-27
Fixed acosh failing docstrings.
dffba76
@Sai-Suraj-27
Fixed sinh failing docstring tests.
21162b8
@Sai-Suraj-27
Fixed exp failing docstring tests.
8da4781
@Sai-Suraj-27
Fixed hardtanh failing docstring tests.
c8608e1
@Sai-Suraj-27
Partially solved ivy.solve.
4dae1f9
@Sai-Suraj-27
Fixed ivy.l1_loss failing docstring tests.
9efae96
@Sai-Suraj-27
Fixed poisson_nll_loss failing docstrings.
58baed0
@Sai-Suraj-27
Fixed tpu_is_available failing docstrings.
a53d4d2
@Sai-Suraj-27
Fixed log2 failing docstrings.
051baae
@Sai-Suraj-27
Fixed failing tests for ivy.native_array.
e1e8e07
@Sai-Suraj-27
Fixed failing tests for ivy.function_supported_devices.
db3b188
@Sai-Suraj-27
Fixed failing tests for clip_vector_norm
8f63233
@Sai-Suraj-27
Fixed docstring errors for set_min_base.
7f9d9e9
@Sai-Suraj-27
Fixed tensordot docstring failures.
1032b46
@Sai-Suraj-27
Fixed set_tmp_dir docstring failures.
088e293
@Sai-Suraj-27
Fixed few more failures.
24231b5
@Sai-Suraj-27
Merge branch 'main' of https://github.com/unifyai/ivy into fix_docstr…
98dbbc6 
…ings
@Sai-Suraj-27
Fixed vector_norm failing docstring tests.
6a55226
@Sai-Suraj-27
Fixed slogdet failing docstring tests.
0894e6c
@Sai-Suraj-27
Fixed svdvals failing docstring tests.
d71240d
@Sai-Suraj-27
Fixed nested_map failing docstring tests.
38b1593
@Sai-Suraj-27
Fixed max_pool1d failing docstring tests.
58d8fff
@Sai-Suraj-27
Fixed general_inner_product failing docstring tests.
983ce90
@ivy-leaves ivy-leaves added Array API Conform to the Array API Standard, created by The Consortium for Python Data API Standards Ivy API Experimental Run CI for testing API experimental/New feature or request Ivy Functional API labels Feb 4, 2024
vedpatwardhan
vedpatwardhan suggested changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@vedpatwardhan vedpatwardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Sai-Suraj-27, thanks for creating the PR, just requested a few changes 😄

ivy/functional/backends/numpy/linear_algebra.py Outdated Show resolved Hide resolved
ivy/functional/backends/tensorflow/elementwise.py Outdated Show resolved Hide resolved
ivy/functional/backends/torch/general.py Outdated Show resolved Hide resolved
ivy/functional/backends/torch/linear_algebra.py Outdated Show resolved Hide resolved
ivy/functional/ivy/creation.py Outdated Show resolved Hide resolved
ivy/functional/ivy/creation.py Outdated Show resolved Hide resolved
ivy/functional/ivy/data_type.py Outdated Show resolved Hide resolved
@Sai-Suraj-27
Copy link
Contributor Author

Hey, @vedpatwardhan. I made the requested changes, and all the backends are also passing now.
image

vedpatwardhan
vedpatwardhan approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@vedpatwardhan vedpatwardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Feel free to merge the PR, thanks @Sai-Suraj-27 😄

@Sai-Suraj-27 Sai-Suraj-27 merged commit 1f5876b into Transpile-AI:main Feb 7, 2024
134 of 140 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vedpatwardhan vedpatwardhan vedpatwardhan approved these changes

Assignees

@Sarvesh-Kesharwani Sarvesh-Kesharwani

Labels
Array API Conform to the Array API Standard, created by The Consortium for Python Data API Standards Ivy API Experimental Run CI for testing API experimental/New feature or request Ivy Functional API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Ivy Failing Test: tensorflow - layers.rfftn Fixing the failing docstring tests
4 participants
@Sai-Suraj-27 @vedpatwardhan @Sarvesh-Kesharwani @ivy-leaves