Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixed paddle_backend.signbit #28180

Merged
merged 3 commits into from
Feb 13, 2024
Merged

fix: Fixed paddle_backend.signbit #28180

merged 3 commits into from
Feb 13, 2024

Conversation

Sai-Suraj-27
Copy link
Contributor

PR Description

Fix Frontend Failing Test: paddle - pointwise_ops.torch.signbit

image

Related Issue

Closes #28179

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

KareemMAX
KareemMAX reviewed Feb 13, 2024
View reviewed changes
Copy link
Contributor

@KareemMAX KareemMAX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we allow all dtypes instead of restricting the test?

@KareemMAX KareemMAX merged commit 2f1d92d into Transpile-AI:main Feb 13, 2024
136 of 141 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KareemMAX KareemMAX KareemMAX left review comments

Assignees

@joaozenobio joaozenobio

Labels
Paddle Paddle Backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Frontend Failing Test: paddle - pointwise_ops.torch.signbit
4 participants
@Sai-Suraj-27 @KareemMAX @joaozenobio @ivy-leaves