Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jax-backend) - Implementing native jax while loop in nms body #28274

Merged
merged 7 commits into from
Feb 26, 2024
Merged

feat(jax-backend) - Implementing native jax while loop in nms body #28274

merged 7 commits into from
Feb 26, 2024

Conversation

mobley-trent
Copy link
Contributor

@mobley-trent mobley-trent commented Feb 13, 2024 •
edited

PR Description

Related Issue

Closes #28137

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

@NripeshN NripeshN assigned Ishticode and unassigned NripeshN Feb 19, 2024
@mobley-trent mobley-trent marked this pull request as ready for review February 20, 2024 09:57
vedpatwardhan
vedpatwardhan approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@vedpatwardhan vedpatwardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Feel free to merge, thanks @mobley-trent 😄

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 26, 2024
@mobley-trent mobley-trent merged commit e1c93cb into Transpile-AI:main Feb 26, 2024
268 of 281 checks passed
Kacper-W-Kozdon pushed a commit to Kacper-W-Kozdon/ivy that referenced this pull request Feb 27, 2024
@mobley-trent @Kacper-W-Kozdon
feat(jax-backend) - Implementing native jax while loop in nms body (T…
9563832 
…ranspile-AI#28274)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vedpatwardhan vedpatwardhan vedpatwardhan approved these changes

Assignees

@Ishticode Ishticode

Labels
lgtm This PR has been approved by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using jax.lax.while_loop in the jax backend implementation for ivy.nms
4 participants
@mobley-trent @vedpatwardhan @Ishticode @NripeshN