feat: add tf ResourceVariable to frontend #28393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our contributing guide and our PR template.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
ivy-leaves
added
the
TensorFlow Frontend
Sam-Armstrong
commented
Feb 22, 2024
| @@ -53,23 +53,23 @@ def shape(self): | |||
|
|
|||
| def assign(self, value, use_locking=None, name=None, read_value=True): | |||
| ivy.utils.assertions.check_equal( | |||
| value.shape if hasattr(value, "ivy_array") else ivy.shape(value), | |||
| value.ivy_array.shape if hasattr(value, "ivy_array") else ivy.shape(value), | |||
There was a problem hiding this comment.
These assertions were throwing an exception without this change, as the shape returned was a tuple
Kacper-W-Kozdon
pushed a commit
to Kacper-W-Kozdon/ivy
that referenced
this pull request
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.