Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed paddle.math.floor for jax, torch, and tensorflow backends #28420

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

Sai-Suraj-27
Copy link
Contributor

PR Description

Fixed paddle.math.floor for jax, torch, and tensorflow backends

image

Related Issue

Closes #28417
Closes #28418
Closes #28419

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 25, 2024
@Sai-Suraj-27
Copy link
Contributor Author

Sai-Suraj-27 commented Feb 25, 2024

Even though the documentation of paddle paddle says that the supported dtypes are float32, float64 or float16. When we test the function using float16 dtype, it gives error and say's that it supports only float32, float64. So, I removed it as a supported dtype.

Paddle Paddle version: 2.6.0 (Latest)

image

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Feb 25, 2024
@MuhammadNizamani
Copy link
Contributor

Even though the documentation of paddle paddle says that the supported dtypes are float32, float64 or float16. When we test the function using float16 dtype, it gives error and say's that it supports only float32, float64. So, I removed it as a supported dtype.

Paddle Paddle version: 2.6.0 (Latest)

image

@Sai-Suraj-27 I am facing the same issue paddlepaddle docs says something and paddle backed does not support.

@Ishticode
Copy link
Contributor

Even though the documentation of paddle paddle says that the supported dtypes are float32, float64 or float16. When we test the function using float16 dtype, it gives error and say's that it supports only float32, float64. So, I removed it as a supported dtype.
Paddle Paddle version: 2.6.0 (Latest)
image

@Sai-Suraj-27 I am facing the same issue paddlepaddle docs says something and paddle backed does not support.

Yh paddle's docs are sometimes incorrect in this regard. One might have to check manually. or you can write a loop with all dtypes and try except block that you can run for any function and it would clearly show which dtypes are actually supported.

Copy link
Contributor

@Ishticode Ishticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Your are right about paddle docs. Thanks for the efforts. :)

@Ishticode Ishticode merged commit 470af19 into Transpile-AI:main Mar 6, 2024
130 of 141 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
4 participants