Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding the numel, __getnewargs__ and __concat__ methods to the Shape class #28618

Merged
merged 3 commits into from
Mar 21, 2024

Conversation

fnhirwa
Copy link
Contributor

@fnhirwa fnhirwa commented Mar 17, 2024

PR Description

This PR adds numel, __getnewargs__ and __concat__ methods to the Shape class and implemented the unit tests.

Related Issue

part of #28617

close #28654
close #28655
close #28656

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

@fnhirwa fnhirwa marked this pull request as ready for review March 17, 2024 05:18
Copy link
Contributor

@Ishticode Ishticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fnhirwa Hoping you are doing well
Great stuff. Thank you very much for you continuous efforts and contributions. Looks good. I've linked three related issues and this looks good to merge. :)

@Ishticode Ishticode merged commit dd8e812 into ivy-llc:main Mar 21, 2024
141 of 145 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

concat __getnewargs__ numel
2 participants