OUT_OF_BOUNDS datacheck; datacheck.log header row #86
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OUT_OF_BOUNDS datacheck
Checks for latitude > 90 or < -90 or longitude > 180 or < -180
Google coped with these cases OK, but Leaflet doesn't like them.
forum thread with discussion
forum thread without discussion
Of course, it would be possible to detect these cases and correct them while loading the waypoint objects from disk. For example, this is what I'm planning for a future commit to yakra/tmtools:
...I already had the datacheck pretty much done before starting on working this out.
For how exactly this would be done in Python, I've not looked that deeply into the code yet.
There's always the possibility than an out-of-bounds coordinate is just completely rubbish, and the "fixed" coordinate from the above function still isn't the intended location. Fixing these just seems like it'd be Good Practice.
Along for the ride: this closes #84.