Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update and rename from chngd.g04w3.wpt to chngd.g0423.wpt #7129

Merged
merged 8 commits into from Jan 6, 2024
Merged

Update and rename from chngd.g04w3.wpt to chngd.g0423.wpt #7129

merged 8 commits into from Jan 6, 2024

Conversation

eeffaann
Copy link
Contributor

@eeffaann eeffaann commented Jan 3, 2024

No description provided.

@eeffaann eeffaann changed the title Patch 1 Update chngd.g04w3.wpt Jan 3, 2024
@eeffaann eeffaann changed the title Update chngd.g04w3.wpt Update and rename from chngd.g04w3.wpt to chngd.g0423.wpt Jan 3, 2024
@jteresco
Copy link
Contributor

jteresco commented Jan 4, 2024

@eeffaann Be sure to discuss this over on the TM forum, thanks!

si404
si404 approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@si404 si404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can see, changes look reasonable

@eeffaann eeffaann marked this pull request as ready for review January 4, 2024 14:40
@eeffaann
Copy link
Contributor Author

eeffaann commented Jan 5, 2024

I guess this is good to merge then @si404?

@jteresco
Copy link
Contributor

jteresco commented Jan 5, 2024

I'm good to bring it in as long as datacheck has been run.

@eeffaann
Copy link
Contributor Author

eeffaann commented Jan 5, 2024 •
edited

I'm good to bring it in as long as datacheck has been run.

Oh how do you run it for a preview system & route, without updating it? Am I missing something @jteresco ...

@jteresco
Copy link
Contributor

jteresco commented Jan 5, 2024

@eeffaann drop me an email (terescoj@gmail.com) and I will send more info (likely not today/tonight though).

@yakra
Copy link
Contributor

yakra commented Jan 6, 2024

I'll give it a go here on my laptop. Cloning; receiving objects 23% ..

@yakra
Copy link
Contributor

yakra commented Jan 6, 2024

!!! DATA CHECK SUCCESSFUL !!!

@jteresco jteresco merged commit c71c78b into TravelMapping:master Jan 6, 2024
@michihdeu
Copy link
Contributor

michihdeu commented Jan 6, 2024 •
edited

I'm good to bring it in as long as datacheck has been run.

Oh how do you run it for a preview system & route, without updating it? Am I missing something @jteresco ...

Are you aware of our manual? The rules and procedures are described there. You'll also find a link to the data check.

@eeffaann eeffaann deleted the patch-1 branch January 7, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@si404 si404 si404 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@eeffaann @jteresco @yakra @michihdeu @si404