Manual: Peer review procedures

[jteresco]

With the CHM manual being migrated to TM and being updated, this is the first of what is likely to be a number of issues about items that need to be fixed or added to the manual.

There should be specific documentation in the manual about the peer review process and its role in preparing a preview system for activation.

[michihdeu]

Some quick thoughts. I'm happy to get some feedback if I missed important steps.
The detailed description will follow later (I hope I can do it in early 2020).

General: Any kind of review helps. Anyone can report issues to the system / region on the forum. Active systems vs. preview systems in the respective board etc.

Thorough peer-review of a preview system to get it active:
1. Agree with the developer of the system that you will do a peer-review (on the forums thread of the system). You should be familar with the manual...
2. Check sources for route list / map indicated on the thread, credits, readme.md,... Have a general look on the system to get familar with the region-specific attitudes. Ask for sources if missing, find additional sources
3. Data check errors incl. NMPs. If there are others than VD, SA, ask the developer for fixing first
4. General mapview, HB or HDX check for missing routes or anything generally looking odd
5. Check route names, banners, city names etc. in HB route list
6. Thorough HDX concurrencies check - not just system but region - to avoid getting confused later. Fixing this is also a danger to break things. Better to have it done before the peer-review
7. WPT editor check route by route for exceeding limits + routing + end position + missing wps, then wp by wp for position and name of non-HB-routes (GSV)
8. HB check route by route to check intersecting HB routes and their names
9. Check forum for questions
10. Final general mapview, HB or HDX check for anything generally looking odd

Report everything to the forum thread, clearly indicate the route names. Make batches especially when it's one of your first or the developers first systems.
Note on the forum if you skipped a step, for instance if HDX is too fancy for you.

[michihdeu]

How to "wp is off" recommendation - feel free to complain 😉

[michihdeu]

Addressed with: #432

@jteresco Please close the issue!