Manual (peer review + credits.php table of content + hb footer #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…beling + formatting
jteresco
reviewed
May 23, 2020
There was a problem hiding this comment.
It's a long time ago and I don't remember any details, but I seem to recall there being some reason we didn't include the footer on pages like the HB and Mapview. It might have just been to maximize available browser real estate for the maps themselves, but there might have been some bad interaction when we had maps that try to fill the window. I'd like to hold off on this for the moment until I have a chance to test it on tmtest (which is currently the very active test area for the new Mapview functionality).
|
I found this: #107 I've undone this change. Please bring the remaining changes live! |
|
Thanks - this is in and live on the main site. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.