Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to main user page from top link bar? #622

Closed
jteresco opened this issue Feb 7, 2021 · 7 comments
Closed

Link to main user page from top link bar? #622

jteresco opened this issue Feb 7, 2021 · 7 comments

Comments

@jteresco
Copy link
Contributor

jteresco commented Feb 7, 2021

A request for a link to the user page from topstats in the forum got me thinking that it might be nice to have a link right to the user page in the link bar that's on all pages. Thoughts? I tend to use TM on devices at least as large as an ipad, and usually a laptop or desktop with plenty of browser real estate. I don't want to cause annoyance to those who might try to access on phones.

@michihdeu
Copy link
Contributor

I generally like the idea.

Would it be disabled if no user is selected?

@jteresco
Copy link
Contributor Author

Candidate implementation on https://tmstage.teresco.org/

@jteresco
Copy link
Contributor Author

Would it be disabled if no user is selected?

Yes, the link is omitted if no user has been selected by URL or browser cookie.

@michihdeu
Copy link
Contributor

Thanks 👍
The user name is missing in the text on updates.php + devel.php + all over the manual etc. though.

@jteresco
Copy link
Contributor Author

Ah, it doesn't work (yet) on pages that previously did not need to know about the user.

@jteresco
Copy link
Contributor Author

I think all pages should have it now.

jteresco added a commit that referenced this issue Feb 15, 2021
jteresco added a commit that referenced this issue Feb 15, 2021
jteresco added a commit that referenced this issue Feb 15, 2021
@jteresco
Copy link
Contributor Author

I think we've got it. Thanks to @michihdeu for the testing.

jteresco added a commit that referenced this issue Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants