Upgrade to ispc 1.1.0 with cleaned up bindings file
#12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
commented
Jun 29, 2022
Comment on lines
+5
to
+6
| pub type __uint8_t = ::std::os::raw::c_uchar; | ||
| pub type __uint32_t = ::std::os::raw::c_uint; |
There was a problem hiding this comment.
I haven't understood this one though, bindgen keeps it around even though it's unused. It disappears under Windows.
Jasper-Bekkers
approved these changes
Jun 29, 2022
MarijnS95
force-pushed
the
ispc-1.1
branch
2 times, most recently
from
3c8e3fc
to
ba0b98e
Compare
`ispc_compile` can now be configured to omit irrelevant bindings from the bindings file and leave only the function(s) in place that are relevant to interface with the ISPC kernel (Twinklebear/ispc-rs#20). This makes the file less busy/noisy, and it won't change when regenerating across OS-es anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ispc_compilecan now be configured to omit irrelevant bindings from the bindings file and leave only the function(s) in place that are relevant to interface with the ISPC kernel (Twinklebear/ispc-rs#20). This makes the file less busy/noisy, and it won't change when regenerating across OS-es anymore.