Preserve alpha coverage on downsample in ISPC #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janie177
approved these changes
Sep 4, 2023
MarijnS95
reviewed
Sep 4, 2023
MarijnS95
reviewed
Sep 4, 2023
MarijnS95
reviewed
Sep 4, 2023
MarijnS95
reviewed
Sep 4, 2023
Co-authored-by: Marijn Suijten <marijn@traverseresearch.nl>
MarijnS95
reviewed
Sep 4, 2023
MarijnS95
reviewed
Sep 4, 2023
MarijnS95
reviewed
Sep 4, 2023
MarijnS95
reviewed
Sep 6, 2023
| @@ -35,10 +35,42 @@ impl<'a> Image<'a> { | |||
| } | |||
| } | |||
|
|
|||
| /// Scales the alpha to the downscaled texture to preserve the overall alpha coverage. | |||
| /// | |||
| /// If alpha cutoff is specified, any alpha value above it is considered visible of | |||
There was a problem hiding this comment.
Suggested change
| /// If alpha cutoff is specified, any alpha value above it is considered visible of | |
| /// If `alpha_cutoff` is specified, any alpha value above it is considered visible of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #33 , but implemented in ISPC an separated as discussed