Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃獰 Add aarch64 windows build #40

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Conversation

Jasper-Bekkers
Copy link
Member

Compiled with ispc 1.20 because ispc 1.22 ran into an internal compiler error (reported here: ispc/ispc#2713)

@MarijnS95
Copy link
Member

Can we add this to the CI (instead)?

@MarijnS95
Copy link
Member

@MarijnS95
Copy link
Member

thread 'main' panicked at C:\Users\runneradmin.cargo\registry\src\index.crates.io-6f17d22bba15001f\ispc_compile-2.0.0\src\lib.rs:437:14:
Failed to find lib.exe for MSVC toolchain, aborting

@Jasper-Bekkers what do contributors and the CI need to install (on Windows) to be able to cross-compile the ISPC binary for this target when making changes to the ISPC files?

@MarijnS95
Copy link
Member

Or was this all installed (Visual Studio Installer) and performed natively on the machine? I'm not sure how easy it would be to invoke that tool to add the aarch64 toolchain in the CI...

But I recall seeing such a setup in win32metadata which we could borrow.

@Jasper-Bekkers
Copy link
Member Author

I think just a recent version of VS with support for arm64. I ran this from the Developer Commandline that ships with VS2022.

@Jasper-Bekkers
Copy link
Member Author

I would wager a guess that GitHub doesn't have that toolchain installed (yet).

@Jasper-Bekkers Jasper-Bekkers merged commit ec3de05 into main Dec 1, 2023
10 checks passed
@MarijnS95
Copy link
Member

Were you building natively on the device? Then it makes obvious sense that you can build for the target.

Alas, expect this file to get out of date if you don't add the CI for it :(

@Jasper-Bekkers
Copy link
Member Author

No I was cross compiling.

I'd love to see CI for it, but it looked like the CI step you tried didn't work, right?

@MarijnS95
Copy link
Member

I've got a fix: Twinklebear/ispc-rs#28

Haven't really checked why the 5-year-old gcc crate was finding lib.exe for @Jasper-Bekkers but it doesn't really matter since our CI process does now too! https://github.com/Traverse-Research/ispc-downsampler/actions/runs/7089720459/job/19295068304

@MarijnS95 MarijnS95 deleted the add-windows-aarch64 branch December 5, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants