Fix generate binaries action after upload-artifacts bump #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jasper-Bekkers
approved these changes
Feb 19, 2024
|
Oh that's sad and I hope there's a way to back out of that. The entire advantage was that we could build one downloadable artifact from multiple individual jobs 🙂 Good find though :) EDIT: Reading https://github.com/actions/upload-artifact?tab=readme-ov-file#not-uploading-to-the-same-artifact, this is intentional and there's no way to go back to the old behaviour. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependabot bumped upload-artifacts from v3 to v4 which has a breaking change that artifacts with the same name can no longer be uploaded. As a result, the generate binaries action would need to be run 3 times to generate all the binaries, which is annoying.
The only fix outlined for this change is to upload different named artifacts. An alternative thing we can do is to do download the artifacts at the end and zip them together.