Skip to content
This repository has been archived by the owner on Oct 19, 2023. It is now read-only.

Fix props type check. #9

Merged
merged 1 commit into from
Jan 4, 2018
Merged

Fix props type check. #9

merged 1 commit into from
Jan 4, 2018

Conversation

Dallas62
Copy link

@Dallas62 Dallas62 commented Jan 3, 2018

Fix type checking introduced in #8 .

This avoid Warning when using StyleSheet.create() which is returning a number as reference.

@Dallas62 Dallas62 changed the title Fix props type checking. Fix props type check. Jan 3, 2018
@Traviskn Traviskn merged commit e657a1f into Traviskn:master Jan 4, 2018
@Traviskn
Copy link
Owner

Traviskn commented Jan 4, 2018

Thanks @Dallas62!

@rosskhanas
Copy link
Contributor

This PR breaks the app on a release mode.

Check this issue and comment: facebook/react-native#16542 (comment)

@Dallas62 @Traviskn

@Dallas62
Copy link
Author

Dallas62 commented Jan 4, 2018

I'm looking on it

@Dallas62 Dallas62 mentioned this pull request Jan 4, 2018
@Traviskn
Copy link
Owner

Traviskn commented Jan 5, 2018

Thanks for reporting @rtkhanas, I've just published a new version to NPM that has @Dallas62's fix!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants