fix selected date in calendar for different timezones #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for travix-ui-kit ready! Built with commit cbb6f1f |
rbardini
reviewed
Jan 15, 2019
| @@ -246,7 +251,7 @@ export default class Calendar extends Component { | |||
| onMouseDown={this.handleItemMouseDown} | |||
| onNavNextMonth={() => this.moveToMonth(CALENDAR_MOVE_TO_NEXT)} | |||
| onNavPreviousMonth={() => this.moveToMonth(CALENDAR_MOVE_TO_PREVIOUS)} | |||
| onSelectDay={e => this.onSelectDay(new Date(e.currentTarget.getAttribute('data-date')))} | |||
| onSelectDay={e => this.onSelectDay(e.currentTarget.getAttribute('data-date'))} | |||
There was a problem hiding this comment.
Any specific reason to not pass a date object to onSelectDay anymore?
There was a problem hiding this comment.
No any specific reason, for me it just looks better and simpler.
DzmitryKukharuk
approved these changes
Jan 15, 2019
EduardTrutsyk
approved these changes
Jan 15, 2019
alinpiaa
approved these changes
Jan 15, 2019
rbardini
approved these changes
Jan 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do:
Fix selected date in the calendar for different zones