Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar should roll away on selection #145

Closed
scottkellum opened this issue Jan 25, 2011 · 5 comments
Closed

Sidebar should roll away on selection #145

scottkellum opened this issue Jan 25, 2011 · 5 comments
Milestone

Comments

@scottkellum
Copy link
Contributor

After you select where you want to go the sidebar should become inactive.

@bramstein
Copy link
Member

You should probably use a menu for cases where you want the box to close when an item is selected. With the most recent changes you can use multiple sidebars and menus, so you can style a menu like a sidebar and achieve that behaviour.

Menu and sidebar are a bit awkward names, it is better to think of them as a container that closes when a mouse is clicked anywhere (menu) and a container that is closed when a mouse is clicked anywhere but the container or other containers of the same type (sidebar.) Perhaps we should come up with better names, any suggestions?

@fortes
Copy link
Contributor

fortes commented Apr 2, 2011

Will need to support scrolling/swiping on these menu/sidebar hybrids as well. Will need to think about this design.

andreacampi pushed a commit to andreacampi/treesaver that referenced this issue Feb 27, 2012
@andreacampi
Copy link
Member

Sorry about the multiple pushes, I made a mess while rebasing :)

Bram:

Menu and sidebar are a bit awkward names, it is better to think of them as a container that closes when a mouse is
clicked anywhere (menu) and a container that is closed when a mouse is clicked anywhere but the container or other
containers of the same type (sidebar.)

I agree with the general principle; still, sidebars scroll and menus don't, so in general they are what people want.
Having the option of closing the sidebar automatically on click is really neat.

@andreacampi
Copy link
Member

Pull request is #280

scottkellum added a commit that referenced this issue Feb 27, 2012
Auto-close the sidebar on click (#145).
@andreacampi
Copy link
Member

An implementation of this has been merged a while back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants