2102: Fix map_lexicographical compare bug

TrenchBroom · Oct 14, 2021 · 1043f07 · 1043f07
1 parent b6e2515
commit 1043f07
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/kdl/include/kdl/map_utils.h b/lib/kdl/include/kdl/map_utils.h
@@ -92,7 +92,7 @@ namespace kdl {
                     return false;
                 } else {
                     const V& lhs_value = lhs.second;
-                    const V& rhs_value = lhs.second;
+                    const V& rhs_value = rhs.second;
                     return value_cmp(lhs_value, rhs_value);
                 }
             });

diff --git a/lib/kdl/test/src/map_utils_test.cpp b/lib/kdl/test/src/map_utils_test.cpp
@@ -105,6 +105,13 @@ namespace kdl {
             { 2, 3 },
             { 3, 4 },
         });
+        test_map_lexicographical_compare<int, int>(-1, {
+            { 1, 2 },
+            { 2, 3 }
+        }, {
+            { 1, 2 },
+            { 2, 4 }
+        });
     }
 
     template<typename K, typename V>