Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor crashes when some entity attributes specified twice #1485

Closed
mittorn opened this issue Oct 16, 2016 · 1 comment
Closed

Editor crashes when some entity attributes specified twice #1485

mittorn opened this issue Oct 16, 2016 · 1 comment
Labels
Prio:1 Highest priority: Crash or crippling bugs, features that enable new ways of working Type:Bug Errors and problems
Milestone
TrenchBroom 2.0.0

Comments

@mittorn
Copy link
Contributor

mittorn commented Oct 16, 2016 •
edited

I could not load map220 map and the reason was in "classname" field, specified two times.

TrenchBroom: /home/mittorn/TrenchBroom/common/src/Model/EntityAttributes.cpp:289: std::list<TrenchBroom::Model::EntityAttribute>::const_iterator TrenchBroom::Model::EntityAttributes::findAttribute(const AttributeName&) const: Assertion `matches.size() == 1' failed.

Assert will crash process. Not specified or specified multiply times classname is not a reason for crash.
Maybe it is better to make warning (As map issue), that entity has wrong fields?
Asserts in CharArrayReader seems to be fixed after develop branch update and i can get it fail only with broken wad. Maybe it is better to use exceptions like in old versions?
@kduske kduske added this to the TrenchBroom 2.0.0 milestone Oct 16, 2016
@kduske kduske added Type:Bug Errors and problems Platform:All Prio:1 Highest priority: Crash or crippling bugs, features that enable new ways of working labels Oct 16, 2016
kduske added a commit that referenced this issue Oct 16, 2016
@kduske
#1485: Ignore duplicate entity properties during parsing.
b2b6622
kduske added a commit that referenced this issue Oct 16, 2016
@kduske
Merge pull request #1486 from kduske/feature/1485
891faa8 
#1485: Ignore duplicate entity properties during parsing.
@kduske
Copy link
Collaborator

kduske commented Oct 16, 2016

Fixed in b2b6622.

@kduske kduske closed this as completed Oct 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Prio:1 Highest priority: Crash or crippling bugs, features that enable new ways of working Type:Bug Errors and problems
Projects
None yet
Milestone
TrenchBroom 2.0.0
Development

No branches or pull requests
2 participants
@kduske @mittorn