Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Move brushes to ..." should select all brushes in the resulting merged func #1494

Closed
ericwa opened this issue Oct 20, 2016 · 4 comments
Closed
Labels
Prio:3 Low priority: Minor problems and nice to have features Type:Enhancement New features

Comments

@ericwa
Copy link
Collaborator

ericwa commented Oct 20, 2016

Current behaviour is:

  1. create two brushes, A is worldspawn, and make B a func_wall
  2. cmd+click A, then B
  3. right click and choose "move brushes to func_wall"
  4. A will be selected, B is deselected

I'd prefer if the entire func_wall (A and B) were selected at this point (how TB1 behaved).

One reason to select all brushes in the merged func is, since the order of selections matters for determining what is merged into what, if you accidentally merge in the wrong direction (trying to merge a few brushes from entity X into entity Y, but instead you merge entity Y into entity X), you won't see it unless you double click to select all brushes in the merged func.

@kduske
Copy link
Collaborator

kduske commented Oct 20, 2016

The reason for the current behavior is that it allows you to see what has actually changed.

@kduske kduske added this to the TrenchBroom 2.0.0 milestone Oct 20, 2016
@kduske kduske added Type:Enhancement New features Platform:All Prio:3 Low priority: Minor problems and nice to have features labels Oct 20, 2016
@kduske
Copy link
Collaborator

kduske commented Oct 20, 2016

Why do you have to select all brushes to see what has been merged into what?

@ericwa
Copy link
Collaborator Author

ericwa commented Oct 20, 2016

Why do you have to select all brushes to see what has been merged into what?

This applies to the use case when you have two existing func_details (say, buildings) and you want to transfer a few brushes from one to the other. Without selecting all brushes in the merged result, the only other visual hint telling you which direction the merge happened is the bounding box, which can be easy to miss. (in this case if you merge in the "wrong" direction, you'll end up with both buildings in a single func_detail)

@ericwa
Copy link
Collaborator Author

ericwa commented Oct 22, 2016

Fixed in a2248d8

@ericwa ericwa closed this as completed Oct 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Prio:3 Low priority: Minor problems and nice to have features Type:Enhancement New features
Projects
None yet
Development

No branches or pull requests

2 participants