Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide checksums with releases #1686

Closed
kduske opened this issue Jan 23, 2017 · 4 comments
Closed

Provide checksums with releases #1686

kduske opened this issue Jan 23, 2017 · 4 comments
Assignees
@kduske
Labels
Prio:2 Medium priority: Non crash bugs that impede the user, features that add new functionality.
Milestone
TrenchBroom 2.0.0

Comments

@kduske
Copy link
Collaborator

kduske commented Jan 23, 2017

No description provided.

@kduske kduske added this to the TrenchBroom 2.0.0 milestone Jan 23, 2017
@kduske kduske added Platform:All Prio:2 Medium priority: Non crash bugs that impede the user, features that add new functionality. labels Jan 23, 2017
@kduske
Copy link
Collaborator Author

kduske commented Jan 23, 2017

@ericwa Is this something we could do? I guess it's either an additional command in the build scripts, or we could see if cpack supports generating a checksum automatically?

@ericwa
Copy link
Collaborator

ericwa commented Jan 23, 2017

CMake 3.7 added a feature so cpack can generate a file with the checksum:
https://cmake.org/cmake/help/v3.7/module/CPack.html#variable:CPACK_PACKAGE_CHECKSUM

It would be ideal if we could make appveyor/travis upload a checksum file for each artifact, in addition to the dmg/rpm/deb/7z.. then we wouldn't have to bother copy/pasting checksums for each release.

Appveyor has cmake 3.7.. Travis I'm guessing doesn't, maybe there is an ubuntu PPA for it though

@kduske
Copy link
Collaborator Author

kduske commented Jan 23, 2017

We only depend on Cmake 3.1 and I'm not too keen on increasing that requirement. On Mac OS X, there's shasum and I assume that also exists on Linux in some form or other.

On Windows, there's several options, too: http://superuser.com/questions/245775/is-there-a-built-in-checksum-utility-on-windows-7

@kduske
Copy link
Collaborator Author

kduske commented Jan 23, 2017

For example, this looks like it does what we need here: https://support.microsoft.com/en-us/help/841290/availability-and-description-of-the-file-checksum-integrity-verifier-utility

@kduske kduske mentioned this issue Jan 26, 2017
Merged
@kduske kduske self-assigned this Jan 26, 2017
@kduske kduske closed this as completed Jan 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kduske kduske

Labels
Prio:2 Medium priority: Non crash bugs that impede the user, features that add new functionality.
Projects
None yet
Milestone
TrenchBroom 2.0.0
Development

No branches or pull requests
2 participants
@kduske @ericwa