Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1686: Add support for generating and uploading checksum files for releases #1693

Merged
merged 8 commits into from Jan 26, 2017

Conversation

kduske
Copy link
Collaborator

@kduske kduske commented Jan 26, 2017

Closes #1686.

Notes:

  • I had to convert the appveyor build script to an external batch file since I needed to call another batch file, and I needed to use labels, both of which I couldn't get working with the embedded powershell script.
  • The checksums are created using cmake itself via the md5sum command. To obtain the correct filenames, we generate the appropriate scripts in TrenchBroomApp.cmake by converting cmake/GenerateChecksum.bat.in and cmake/GenerateChecksum.sh.in.
  • There is a test release with the results here: https://github.com/kduske/TrenchBroom/releases/tag/v2.0.0-checksum_test_3

@kduske kduske requested a review from ericwa January 26, 2017 08:36
@kduske kduske self-assigned this Jan 26, 2017
Copy link
Collaborator

@ericwa ericwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, my only question is will
echo "Building TrenchBroom failed"
in appveyor.bat be enough to make to make the appveyor build fail?
Does it also need the .bat equivalent of "exit 1"?

@kduske kduske merged commit 64ff944 into release/v2.0.0 Jan 26, 2017
@kduske
Copy link
Collaborator Author

kduske commented Jan 26, 2017

Done, thanks! I'll merge it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants