Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some missing pieces for better FreeBSD support #1689

Closed
danfe opened this issue Jan 24, 2017 · 4 comments
Closed

Some missing pieces for better FreeBSD support #1689

danfe opened this issue Jan 24, 2017 · 4 comments
Assignees
Labels
Prio:2 Medium priority: Non crash bugs that impede the user, features that add new functionality.

Comments

@danfe
Copy link

danfe commented Jan 24, 2017

TB got most Linux/FreeBSD/Unix stuff sorted out earlier, but recent changes introduced couple of minor issues. Consider attached (very simple) patch.

@danfe
Copy link
Author

danfe commented Jan 24, 2017

Just an after-thought: perhaps instead of checking for Linux or FreeBSD (and potentially other Unix-like systems), it makes more sense to use #ifndef _WIN32 (speaking of common/src/IO/SystemPaths.cpp)?

@kduske kduske self-assigned this Jan 24, 2017
@kduske kduske added Platform:FreeBSD Prio:2 Medium priority: Non crash bugs that impede the user, features that add new functionality. labels Jan 24, 2017
@kduske kduske added this to the TrenchBroom 2.0.0 milestone Jan 24, 2017
@kduske
Copy link
Collaborator

kduske commented Jan 24, 2017

Please have a look at #1690. It looks like your patch was made against an older revision or some branch that no longer is used. You should base your builds on branch release/v2.0.0 or master if you want the latest changes. All changes but the one in SystemPaths.cpp were already there.

Just an after-thought: perhaps instead of checking for Linux or FreeBSD (and potentially other Unix-like systems), it makes more sense to use #ifndef _WIN32 (speaking of common/src/IO/SystemPaths.cpp)?

No, the TB_DEV_MODE environment variable was introduce to allow TB to run without installation on systems that expect resources to be in Unix-like locations, which is not the case for OS X.

@danfe
Copy link
Author

danfe commented Jan 24, 2017

Ah, sorry, I was responding to your call to test RC1, so my patch was against it, not the trunk. As a packager, I prefer to work with releases (or pre-releases), not the Git checkouts. I'll try to follow master branch more closely though to give you less trouble. Thanks!

@kduske
Copy link
Collaborator

kduske commented Jan 24, 2017

For the time being, you should base on release/v2.0.0 as that is considered stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Prio:2 Medium priority: Non crash bugs that impede the user, features that add new functionality.
Projects
None yet
Development

No branches or pull requests

2 participants