Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Remove Objects from Group" also moves from brush entities to worldspawn #1744

Closed
ericwa opened this issue Mar 20, 2017 · 1 comment
Closed

"Remove Objects from Group" also moves from brush entities to worldspawn #1744

ericwa opened this issue Mar 20, 2017 · 1 comment
Assignees
@ericwa
Labels
Prio:3 Low priority: Minor problems and nice to have features Type:Bug Errors and problems
Milestone
TrenchBroom 2.0.0

Comments

@ericwa
Copy link
Collaborator

ericwa commented Mar 20, 2017

RC3 / macOS.

  • Turn a brush into a func_door, then create a group with the func_door.
  • Double click to enter the group, then right-click on the func_door brush and choose "Remove object from group Untitled"
  • I'm expecting the func_door brush to be moved outside of the group (but still staying in the func_door), but instead the brush is moved out of the group and moved to worldspawn.

So to summarize this and #1706,

Current behaviour:

  • "Move brushes to world" - removes from group and moves to worldspawn
  • "Remove objects from group" - removes from group and moves to worldspawn

Proposed:

  • "Move brushes to world" - stays in group and moves to worldspawn
  • "Remove objects from group" - removes from group and stays in brush entity, if any
@kduske kduske added this to the TrenchBroom 2.0.0 milestone Mar 20, 2017
@kduske kduske added Platform:All Prio:3 Low priority: Minor problems and nice to have features Type:Bug Errors and problems labels Mar 20, 2017
@ericwa ericwa self-assigned this Mar 20, 2017
@ericwa
Copy link
Collaborator Author

ericwa commented Mar 20, 2017

"Add objects to group" has the same issue (adding a func_door to an existing group causes the func_door brushes to be moved to worldspawn).. I'm fixing that at the same time.

ericwa added a commit that referenced this issue Mar 20, 2017
@ericwa
#1744: Make "Add/remove objects to/from group" commands preserve brus…
4b78a55 
…h entities

Note: if you try to add/remove a single brush of a brush entity to/from a group, it will add/remove the whole brush entity.
@ericwa ericwa mentioned this issue Mar 20, 2017
Merged
kduske pushed a commit that referenced this issue Mar 21, 2017
@ericwa @kduske
#1744: Make "Add/remove objects to/from group" commands preserve brus…
05ad0d6 
…h entities (#1745)

Note: if you try to add/remove a single brush of a brush entity to/from a group, it will add/remove the whole brush entity.
@ericwa ericwa closed this as completed Mar 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericwa ericwa

Labels
Prio:3 Low priority: Minor problems and nice to have features Type:Bug Errors and problems
Projects
None yet
Milestone
TrenchBroom 2.0.0
Development

No branches or pull requests
2 participants
@kduske @ericwa