Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing mod directory blocks palette from being loaded #2574

Closed
ericwa opened this issue Feb 5, 2019 · 0 comments
Closed

Missing mod directory blocks palette from being loaded #2574

ericwa opened this issue Feb 5, 2019 · 0 comments
Assignees
@ericwa
Labels
Prio:1 Highest priority: Crash or crippling bugs, features that enable new ways of working Type:Bug Errors and problems
Milestone
2019.3

Comments

@ericwa
Copy link
Collaborator

ericwa commented Feb 5, 2019

Load this as a Quake map:
missing_mod_dir.map.txt

The palette won't load, and the entity browser will be empty. Commenting out the invalid "_tb_mod" line fixes the problem.

14:05:10: Debug: Adding file system path /home/ericwa/QuakeDev/id1
14:05:10: Debug: Adding file system package pak0.pak
14:05:10: Debug: Adding file system package pak1.pak
14:05:10: Debug: Loading document from /home/ericwa/Desktop/test2.map
14:05:10: Debug: Adding file system path /home/ericwa/QuakeDev/id1
14:05:10: Debug: Adding file system package pak0.pak
14:05:10: Debug: Adding file system package pak1.pak
14:05:10: Debug: Adding file system path /home/ericwa/QuakeDev/some_directory_that_does_not_exist
14:05:10: Debug: Could not add file system search path '/home/ericwa/QuakeDev/some_directory_that_does_not_exist': Directory not found: '/home/ericwa/QuakeDev/some_directory_that_does_not_exist'
14:05:10: Debug: Loaded entity definition file Quake.fgd
14:05:10: Debug: Loading palette file gfx/palette.lmp
14:05:10: Debug: Could not load palette file 'gfx/palette.lmp': File not found: 'gfx/palette.lmp'

Tested on current master ( 8993b3f ) with #2572 merged in
@kduske kduske added this to the 2019.3 milestone Feb 5, 2019
@kduske kduske added Type:Bug Errors and problems Prio:1 Highest priority: Crash or crippling bugs, features that enable new ways of working labels Feb 5, 2019
ericwa added a commit that referenced this issue Feb 5, 2019
@ericwa
2574: change FileSystem::m_next to std::shared_ptr
004a83d 
There is shared ownership during construction of the
filesystems (e.g. Quake3ShaderFileSystem needs to access m_next in its
constructor, and the code calling the constructor needs to keep a
reference to the filesystem chain.)

Fixes #2574
@ericwa ericwa mentioned this issue Feb 5, 2019
Merged
@ghost ghost added the Status:In Progress label Feb 5, 2019
ericwa added a commit that referenced this issue Feb 6, 2019
@ericwa
2574: change FileSystem::m_next to std::shared_ptr (#2575)
0eefd78 
* 2574: change FileSystem::m_next to std::shared_ptr

There is shared ownership during construction of the
filesystems (e.g. Quake3ShaderFileSystem needs to access m_next in its
constructor, and the code calling the constructor needs to keep a
reference to the filesystem chain.)

Fixes #2574

* 2574: clarify comment
@ghost ghost removed the Status:In Progress label Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericwa ericwa

Labels
Prio:1 Highest priority: Crash or crippling bugs, features that enable new ways of working Type:Bug Errors and problems
Projects
None yet
Milestone
2019.3
Development

No branches or pull requests
2 participants
@kduske @ericwa