Using vertex/edge/face tool on a brush breaks view filters

[ericwa]

System Information

• current master on Windows 10
• RC2 reported by muk
• also 2019.6, so it's an old bug

Expected Behavior

Using edge tool shouldn't break view filters.

Steps to Reproduce

1. New quake map.
2. Add a wad with liquid textures, I used ikbase
3. Click the starting brush, apply a liquid texture (I used *slimeik1)
4. Press "e", move an edge, press Esc, Esc, Esc to return to the default tool and deselect the brush
5. Click View ->Uncheck "Show Liquid". The brush won't hide

The "Show Liquid" view filter does work on brushes that are just modified by shift+dragging faces, so the vertex tools are somehow connected to this bug.

[neogeographica]

Same thing e.g. with Quake 3 and a detail brush. However if I save the map, all the faces are still detail. If I quit TB and reload that saved map, the hide/show now works as expected.

[neogeographica]

FWIW in the detail brush example above, when things are broken each face of the brush has a zero for m_tagMask. When things are working (either before the edge move, or after quitting and reloading) each face has an m_tagmask of 36.

[ericwa]

Nice. We're probably just forgetting to re-generate the automatic tags after the vertex edit, or something.

[neogeographica]

BrushFace::clone() needs a fix perhaps?

edit: Yeah that looks plausible. Traced in gdb to check.