Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make worldspawn's classname property read only #3783

Closed
kduske opened this issue Mar 13, 2021 · 2 comments · Fixed by #3788
Closed

Make worldspawn's classname property read only #3783

kduske opened this issue Mar 13, 2021 · 2 comments · Fixed by #3788
Assignees
@ericwa
Labels
Type:Bug Errors and problems
Milestone
2022.1

Comments

@kduske
Copy link
Collaborator

kduske commented Mar 13, 2021

It is currently possible to change worldspawn's classname, which will have weird side effects, esp. when the map is saved and opened again. I think we should prevent this. It is already impossible to rename worldspawn's classname property, too.
@kduske kduske added the Type:Bug Errors and problems label Mar 13, 2021
@kduske
Copy link
Collaborator Author

kduske commented Mar 13, 2021

@ericwa Do you have any thoughts?

@ericwa
Copy link
Collaborator

ericwa commented Mar 13, 2021

Yeah this sounds fine

@ericwa ericwa self-assigned this Mar 14, 2021
ericwa added a commit that referenced this issue Mar 14, 2021
@ericwa
3783: protect renaming classname value
e6d82c5 
Fixes #3783
@ericwa ericwa mentioned this issue Mar 14, 2021
Merged
ericwa added a commit that referenced this issue Mar 14, 2021
@ericwa
3783: protect renaming classname value
63e32b6 
Fixes #3783
@kduske kduske added this to the 2022.2 milestone May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericwa ericwa

Labels
Type:Bug Errors and problems
Projects
None yet
Milestone
2022.1
Development

Successfully merging a pull request may close this issue.

3783: protect renaming classname value TrenchBroom/TrenchBroom
2 participants
@kduske @ericwa