#1493: Add explicit command to reset the texture of a brush. #1497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, why can't I see the Travis and Appveyor builds anymore? |
ericwa
reviewed
Oct 21, 2016
| @@ -147,11 +147,16 @@ namespace TrenchBroom { | |||
| if (m_texture != NULL) { | |||
There was a problem hiding this comment.
It doesn't look like setTexture() is ever called with null now.
Add an expect(texture != null, "can't set texture to null");?
There was a problem hiding this comment.
Yes, it can still be called with a NULL texture, see MapDocument::UnsetTextures. The difference is that setTexture(NULL) doesn't change the texture name while unsetTexture does.
|
Looks good and works for me!
|
They're showing up for me if I click "Show all checks". Maybe it was just the Github outage earlier today? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ericwa this should fix #1493. Could you have quick look around?