EntityModelManager::renderer: catch exceptions thrown by model() #1531
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1525
(both the crash when loading ad_quake.fgd in ad_magna.map, and the quoth flashlight example)
There is already a
View::safeGetModel()
function in ViewUtils but it takes a logger reference, which isn't desirable in this case:EntityModelManager::model()
already prints a warning to its logger if the model fails to load, soEntityModelManager::renderer()
can just ignore and return NULL ifmodel()
throws an exception.