EntityAttributeGridTable: fix deleting rows with default values #1532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…andle deleting a row with a default value
ericwa
commented
Dec 7, 2016
|
|
||
| Transaction transaction(document, StringUtils::safePlural(numRows, "Remove Attribute", "Remove Attributes")); | ||
| { | ||
| const SetBool ignoreUpdates(m_ignoreUpdates); |
There was a problem hiding this comment.
Note: I didn't modify this code, just indented and wrapped it in {} to limit the lifetime of the SetBool.
|
Did you try these changes on Windows or Mac only? The grid control behaves slightly differently on the different platforms. |
|
I tested on Mac only |
|
I checked it on Windows in the meantime, works fine there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1527
I removed this comment:
because that seems to be implemented already (?)