Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use logical and operator to check spawnflags in FGD files. #1581

Merged
merged 2 commits into from
Dec 27, 2016
Merged

Use logical and operator to check spawnflags in FGD files. #1581

merged 2 commits into from
Dec 27, 2016

Conversation

kduske
Copy link
Collaborator

@kduske kduske commented Dec 26, 2016

Issue: #1534

This change required some minor changes to the EL:

  • Allow null values to be type convertible to other types.
  • Allow blank strings to be convertible to numbers.

Also required a change to the variable store for entity attributes, which now returns an empty string for missing variables.

@kduske
#1534: Allow type conversion from null and allow blank strings to be …
1af20f6 
…converted to numbers. Return empty string variable values for missing entity attributes.
@kduske
#1534: Adapt expressions in FGD files: Use logical and to check for s…
c2c1019 
…pawnflags.
@kduske kduske requested a review from ericwa December 26, 2016 22:48
@kduske kduske self-assigned this Dec 26, 2016
ericwa
ericwa approved these changes Dec 27, 2016
View reviewed changes
Copy link
Collaborator

@ericwa ericwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Gave it a quick test and it resolves #1534

@kduske kduske merged commit 5504755 into release/v2.0.0 Dec 27, 2016
@kduske
Copy link
Collaborator Author

kduske commented Dec 27, 2016

Thanks!

@kduske kduske deleted the feature/1534 branch November 6, 2017 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericwa ericwa ericwa approved these changes

Assignees

@kduske kduske

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kduske @ericwa