#1654: Handle entity properties containing double quotation marks

[kduske]

Closes #1654.

Double quotation marks are marked as issues. Two quick fixes are available: Delete property and Replace double with single quotation marks. Furthermore, they are escaped with backslashes when writing a map, and are unescaped when reading again.

[ericwa]

Pasting this:

// entity 0
{
"classname" "monster_knight"
"origin" "-48 -16 40"
"angle" "-0"
"message" "test\\\\"
}

shows up in the UI as message test\ - one of the slashes gets lost.

Otherwise everything looks good.

[kduske]

That's because it interprets two consecutive backslashes as one escaped backslash. So strictly speaking, backslashes will have to be escaped, and they are when TB writes the map file.

[kduske]

See also the additional test case.

[ericwa]

Is the escape character esc implicitly included in the chars argument of StringUtils::escape/unescape?

This implies it is:

ASSERT_EQ(String("asdf\\"), StringUtils::unescape("asdf\\\\", ""));

but then this fails:

ASSERT_EQ(String("asdf\\\\"), StringUtils::unescape("asdf\\\\\\\\", ""));

Btw, raw string literals are working in ELParserTest.parseStringLiteralWithDoubleQuotationMarks:
ASSERT_EL_EQ(R"(asdf" "asdf)", R"("asdf\" \"asdf")");
Maybe we can use them in StringUtilsTest as well.

[ericwa]

Will this work?

const String data(R"({)"
                  R"("classname" "worldspawn")"
...

[kduske]

I had used raw string literals, only to have VC++ being unable to parse them. So they are banned, sorry.

[kduske]

Is the escape character esc implicitly included in the chars argument of StringUtils::escape/unescape?

It is.

[kduske]

ASSERT_EQ(String("asdf\\\\"), StringUtils::unescape("asdf\\\\\\\\", ""));

Should not have failed. It's fixed now. Thanks for the thorough review.

[ericwa]

Looks good now!

[kduske]

I'm sure something else will break on windows or something. Goddamn backslashes.