Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1692: Properly handle 'mangle' (yaw pitch roll) entity property. #1694

Merged
merged 3 commits into from Jan 27, 2017

Conversation

kduske
Copy link
Collaborator

@kduske kduske commented Jan 26, 2017

Closes #1692.

@kduske kduske requested a review from ericwa January 26, 2017 19:40
@kduske kduske self-assigned this Jan 26, 2017
@ericwa
Copy link
Collaborator

ericwa commented Jan 26, 2017

For light entities, positive pitch should be aiming up (+Z axis) e.g. "0 45 0" is aiming at a 45 degree angle upwards. TB is rendering that as pointing 45 degrees down from the horizontal.

reference: https://shoresofnis.wordpress.com/guides/lighting-basics/ , and also I tested it in my light tool.

It seems that info_intermission uses an incompatible mangle, where the first component is pitch (!?!):
https://quakewiki.org/wiki/info_intermission

I'd look in to this more, but I'm going away for the weekend, I can check it out on Monday though.

@kduske
Copy link
Collaborator Author

kduske commented Jan 26, 2017

Interesting. It looks like info_intermission's interpretation of mangle is identical to how TB interprets the angles property: -pitch yaw roll. I'll add special treatment.

@kduske
Copy link
Collaborator Author

kduske commented Jan 26, 2017

Alright, that should fix both the pitch and the info_intermission stuff, at least for Quake. I have a feeling that we will run into problems with this in other games.

@kduske
Copy link
Collaborator Author

kduske commented Jan 26, 2017

@ericwa If you could have quick glance, that would be great. If you want to look into it in more detail, you're of course welcome to, but I'll merge this in the meantime. If you find more problems, just open new issues and we'll fix them.

@kduske
Copy link
Collaborator Author

kduske commented Jan 26, 2017

As a sidenote, we should express these rules using the EL in the game config files, as they might differ from game to game.

@kduske kduske merged commit c900fb1 into release/v2.0.0 Jan 27, 2017
@kduske kduske deleted the feature/1692 branch November 6, 2017 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants