New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2711: do AABB removals by an unordered_map lookup rather than spatial search #2719
Conversation
I haven't tested this for memory leaks yet, and I guess the node heights aren't being tested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, very similar to what I had in mind, too. I just have a few minor comments.
Thanks for the review. One last thing I wanted to do was forward-declare AABBTree and wrap it in a unique_ptr, now you can modify AABBTree and only 2 or 3 files recompile instead of dozens. |
Fixes #2711