Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export component types #307

Closed
AykutSarac opened this issue Nov 1, 2022 · 8 comments · Fixed by #449 or #650
Closed

Export component types #307

AykutSarac opened this issue Nov 1, 2022 · 8 comments · Fixed by #449 or #650
Labels
needs clarification Issues that needs more complete description react Issues related with React wrapper released on @beta released

Comments

@AykutSarac
Copy link
Member

Is your feature request related to a problem? Please describe.
Sometimes when creating a custom component using existing Baklava component you could spread props. It would be great to import types of e.g "BlInputType" so we could use it as a type and spread. I'm open for suggestions if any :)

Describe the solution you'd like
Export BlInputType and other component types from baklava-react.d.ts
@olkeoguz olkeoguz added baklava-ds needs clarification Issues that needs more complete description labels Nov 1, 2022
@muratcorlu
Copy link
Contributor

Is this still the case? Do we have component type issues in React now?

@AykutSarac
Copy link
Member Author

AykutSarac commented Dec 6, 2022 •
edited
Loading

This is actually a feature/improvement request rather than a problem.

Basically, when creating a custom element that extends Baklava's Custom Element's props, we need the element's props to extend from it. @olkeoguz might be able to explain it more detailed referring to our previous talks.

@muratcorlu muratcorlu added the react Issues related with React wrapper label Feb 9, 2023
@muratcorlu
Copy link
Contributor

#449 should fix this as well. Can you have a look?

@muratcorlu muratcorlu mentioned this issue Mar 1, 2023
Merged
@github-actions
Copy link

github-actions bot commented Mar 1, 2023

🎉 This issue has been resolved in version 2.0.0-beta.77 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Apr 6, 2023

🎉 This issue has been resolved in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@AykutSarac AykutSarac reopened this Jul 12, 2023
@AykutSarac
Copy link
Member Author

Reopening this issue in favor of #650

@AykutSarac AykutSarac mentioned this issue Jul 12, 2023
Merged
@github-actions
Copy link

🎉 This issue has been resolved in version 2.2.0-beta.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This issue has been resolved in version 2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs clarification Issues that needs more complete description react Issues related with React wrapper released on @beta released
Projects
Baklava Design System
Archived in project
Milestone
No milestone
3 participants
@muratcorlu @AykutSarac @olkeoguz