Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Baklava select input popover close event trigger problem #802

Closed
1 task
oemolla opened this issue Feb 20, 2024 · 2 comments · Fixed by #844
Closed
1 task

[BUG]: Baklava select input popover close event trigger problem #802

oemolla opened this issue Feb 20, 2024 · 2 comments · Fixed by #844
Assignees
@erbilnas
Labels
a11y Accessibility related issues bug Something isn't working bug-confirmed When bug confirmed by the maintainers released

Comments

@oemolla
Copy link
Contributor

oemolla commented Feb 20, 2024

Issue description

When typing in the bl select input, pressing the space bar causes the popover to close.

Media & Screenshots

last

Baklava Version

No response

Operating system

No response

Priority this issue should have

Low (slightly annoying)

Please review the checkboxes that are applicable.

  • This issue is directly related to React
@oemolla oemolla added the bug Something isn't working label Feb 20, 2024
@oemolla oemolla changed the title [BUG]: Baklava select input's popover close event trigger problem [BUG]: Baklava select input popover close event trigger problem Feb 20, 2024
@erbilnas erbilnas mentioned this issue Feb 20, 2024
Closed
@erbilnas erbilnas added bug-confirmed When bug confirmed by the maintainers a11y Accessibility related issues labels Feb 20, 2024
@erbilnas erbilnas self-assigned this Feb 20, 2024
@erbilnas
Copy link
Contributor

merged #796

ogunb added a commit that referenced this issue Apr 25, 2024
@ogunb
fix(select): fix recurring space closing select box issue
524391b 
Keydown is triggered before input,
causing the select keydown handler to run first.

Fixes #802
@ogunb ogunb mentioned this issue Apr 25, 2024
Merged
ogunb added a commit that referenced this issue Apr 29, 2024
@ogunb
fix(select): fix recurring space closing select box issue (#844)
0de50ae 
Keydown is triggered before input,
causing the select keydown handler to run first.

Fixes #802
@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

🎉 This issue has been resolved in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erbilnas erbilnas

Labels
a11y Accessibility related issues bug Something isn't working bug-confirmed When bug confirmed by the maintainers released
Projects
None yet
Milestone
No milestone
2 participants
@oemolla @erbilnas