Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Searchable select hides label #828

Closed
1 task
ogunb opened this issue Apr 16, 2024 · 2 comments · Fixed by #829
Closed
1 task

[BUG]: Searchable select hides label #828

ogunb opened this issue Apr 16, 2024 · 2 comments · Fixed by #829
Labels
bl-select Select Component bug Something isn't working released on @beta released

Comments

@ogunb
Copy link
Contributor

ogunb commented Apr 16, 2024

Issue description

Current implementation of search-bar-placeholder overrides select label and when label-fixed is false.

Media & Screenshots

Current implemetation:
Screenshot 2024-04-16 at 18 06 51
Screenshot 2024-04-16 at 18 07 00

Expected behaviour:
Screenshot 2024-04-16 at 18 07 20
Screenshot 2024-04-16 at 18 07 30

Baklava Version

3.0.0

Operating system

No response

Priority this issue should have

Low (slightly annoying)

Please review the checkboxes that are applicable.

  • This issue is directly related to React
@ogunb ogunb added the bug Something isn't working label Apr 16, 2024
ogunb added a commit that referenced this issue Apr 16, 2024
@ogunb
fix(select): shouln't hide label on searchable
a1116bf 
It was always displaying search placeholder.
Added new stories to the select component in the storybook with label and fixed label options.

Fixes #828
@ogunb ogunb mentioned this issue Apr 16, 2024
Merged
AykutSarac pushed a commit that referenced this issue Apr 17, 2024
@ogunb
fix(select): shouln't hide label on searchable (#829)
d8137c9 
It was always displaying search placeholder.
Added new stories to the select component in the storybook with label
and fixed label options.

Fixes #828
@ogunb ogunb added the bl-select Select Component label Apr 17, 2024
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 3.0.0-beta.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

🎉 This issue has been resolved in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bl-select Select Component bug Something isn't working released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(select): shouln't hide label on searchable Trendyol/baklava
1 participant
@ogunb