New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: button component #118

Merged

muratcorlu merged 26 commits into next from 85-button-component

Jun 13, 2022

Member

leventozen commented May 29, 2022 •

edited

Button component implemented. It's documentation with more detailed information will be provided in different PR.

Closes #118

leventozen added 3 commits

May 22, 2022 16:58


          feat: button component

efa8888


          feat: button component

5e4f115


          chore: added missing stories to button component

8e68bbe

leventozen requested a review from muratcorlu

June 3, 2022 14:54

muratcorlu reviewed

View reviewed changes

src/components/gr-button/gr-button.css Outdated Show resolved Hide resolved

muratcorlu reviewed

View reviewed changes

src/components/gr-button/gr-button.ts Outdated Show resolved Hide resolved

muratcorlu reviewed

View reviewed changes

src/themes/default.css Outdated Show resolved Hide resolved

muratcorlu reviewed

View reviewed changes

src/themes/default.css Outdated Show resolved Hide resolved

muratcorlu reviewed

View reviewed changes

src/themes/default.css Outdated Show resolved Hide resolved

leventozen added 3 commits

June 6, 2022 00:11


          refactor: added css improvements, delete unnecessary tokens from theme

4893c82


          Merge branch 'next' of https://github.com/Trendyol/grace into 85-butt…

158e211

…on-component


          fix: lint css

d5c7ead

Member Author

leventozen commented Jun 5, 2022 •

edited

@buseselvi, we should help user about answering these questions: what for? why? how? when to use?, etc.
Here is the link of our button component. We should provide more details about our variants, etc.

PS: I extracted the tertiary button for now. After we make progress about it like having answers for the questions above and making decisions about its color scheme to prevent inconsistency, I will add.

leventozen marked this pull request as ready for review

June 5, 2022 21:55

leventozen requested a review from buseselvi

June 6, 2022 05:37

leventozen and others added 15 commits

June 7, 2022 01:06


          fix(button): change: grace element to baklava at button

43c863a


          fix: border sizing issue at button component

043d43b


          refactor(button): add new shared variables to button component to mak…

de6ad36

…e more clear structure


          fix(design): lint design tokens

ecb00bc


          refactor(input): style optimizations

75a3a01


          fix(button): style fixes for button variants

3d53e65


          refactor(button): css lint

68ea9ac


          feat(button): breaking very long texts in button

300a8f9


          fix(icon): icon crop issue fixed

a8a93a6


          fix(button): outline disabled hover state fixed

ee9d45a


          fix(button): font sizing problems fixed

a676176


          fix(button): error variant renamed as danger

47dcc5b


          fix(button): prettier fine tune

499f09f


          feat(button): setting icon as attribute

51b83e3


          refactor: lint fixes

73fd1d6

muratcorlu added 5 commits

June 9, 2022 22:30


          docs(design): some typography and color rules documented

913d997


          docs(button): storybook stories simplified

82aed98


          feat(button): link buttons renamed as plain buttons

20780d1


          docs(button): button docs improved

e19b4c3


          refactor(button): some optimizations

679c20f

muratcorlu approved these changes

View reviewed changes

buseselvi approved these changes

View reviewed changes

muratcorlu merged commit ce7c1d4 into next

muratcorlu deleted the 85-button-component branch

June 13, 2022 07:13

github-actions bot commented Jun 13, 2022

🎉 This PR is included in version 2.0.0-beta.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot added the released on @beta label

muratcorlu mentioned this pull request

Button Component #85

Closed

github-actions bot commented Apr 6, 2023

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot added the released label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment