Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

140 tooltip component #159

Merged
merged 10 commits into from Jul 26, 2022
Merged

140 tooltip component #159

merged 10 commits into from Jul 26, 2022

Conversation

DamlaDemir
Copy link
Contributor

Tooltip component completed.

issues 140

@muratcorlu
Copy link
Contributor

Something wrong with storybook file. It’s not published with tooltip component and UI tests are not triggered. Can you check it?

@DamlaDemir DamlaDemir closed this Jul 19, 2022
@DamlaDemir DamlaDemir reopened this Jul 19, 2022
@DamlaDemir DamlaDemir closed this Jul 20, 2022
@DamlaDemir DamlaDemir reopened this Jul 20, 2022
Copy link
Contributor

@muratcorlu muratcorlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! I have some remarks.

src/components/tooltip/bl-tooltip.ts Outdated Show resolved Hide resolved
src/components/tooltip/bl-tooltip.stories.mdx Outdated Show resolved Hide resolved
src/components/tooltip/bl-tooltip.stories.mdx Outdated Show resolved Hide resolved
src/components/tooltip/bl-tooltip.stories.mdx Outdated Show resolved Hide resolved
src/components/tooltip/bl-tooltip.stories.mdx Outdated Show resolved Hide resolved
src/components/tooltip/bl-tooltip.stories.mdx Outdated Show resolved Hide resolved
src/components/tooltip/bl-tooltip.test.ts Outdated Show resolved Hide resolved
src/components/tooltip/bl-tooltip.ts Outdated Show resolved Hide resolved
src/components/tooltip/bl-tooltip.ts Show resolved Hide resolved
src/components/tooltip/bl-tooltip.ts Show resolved Hide resolved
Copy link
Contributor

@muratcorlu muratcorlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@muratcorlu muratcorlu linked an issue Jul 26, 2022 that may be closed by this pull request
@DamlaDemir DamlaDemir merged commit 8759b63 into next Jul 26, 2022
@DamlaDemir DamlaDemir deleted the 140-tooltip-component branch July 26, 2022 08:31
@github-actions
Copy link

🎉 This PR is included in version 2.0.0-beta.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Apr 6, 2023

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip Component
3 participants