Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change typography variables and fix document #254

Merged
merged 6 commits into from Oct 3, 2022

Conversation

DamlaDemir
Copy link
Contributor

@DamlaDemir DamlaDemir commented Sep 28, 2022

Some typography variables were deprecated and new typography variables were added. The typography document was edited.

Closes #92, #235

src/themes/default.css Outdated Show resolved Hide resolved
Copy link
Contributor

@muratcorlu muratcorlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some broken styles as visible in snapshots and I mentioned one in the comments.

@muratcorlu muratcorlu linked an issue Sep 29, 2022 that may be closed by this pull request
@sonarcloud
Copy link

sonarcloud bot commented Oct 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DamlaDemir DamlaDemir merged commit cbbcb6f into next Oct 3, 2022
@DamlaDemir DamlaDemir deleted the add-new-typography branch October 3, 2022 07:05
@github-actions
Copy link

github-actions bot commented Oct 5, 2022

🎉 This PR is included in version 2.0.0-beta.33 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Apr 6, 2023

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation - How to use typography? Design System - Typography Rules
3 participants