feat(drawer): add dynamic width feature to drawer #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdemgonul
force-pushed
the
feat/767-drawer-width-dynamic
branch
from
d39b87f
to
aef4f6e
Compare
|
Can we add a drawer example to the storybook with the custom width feature? 🙏🏻 |
Enes5519
approved these changes
Apr 1, 2024
erbilnas
requested changes
Apr 2, 2024
erbilnas
approved these changes
Apr 3, 2024
|
🎉 This PR is included in version 3.0.0-beta.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds setting width feature into drawer.
Closes #767
This had to be written with JavaScript because it was previously written with @ media, and we couldn't use CSS variables inside @ media. Reference source: https://stackoverflow.com/a/40723269
Also added style-to-px-converter to give width properties like '%', 'vh'