Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): fix disabled select option can be selected with enter #874

Merged
merged 4 commits into from
Jun 6, 2024

Conversation

ahmetozantekin
Copy link
Member

This pr fixes navigating in the select options with the arrow keys, disabled option can be selected with enter bug.

Closes 873

AykutSarac
AykutSarac previously approved these changes May 21, 2024
@buseselvi buseselvi self-requested a review June 6, 2024 07:13
@buseselvi
Copy link
Contributor

buseselvi commented Jun 6, 2024

Great job' 🚀 Since there are bl-checkbox components in the multiple select options, it cannot be selected with enter, but let's open this as a separate issue.

@buseselvi buseselvi merged commit f3d1c35 into next Jun 6, 2024
7 checks passed
@buseselvi buseselvi deleted the fix/873-selectoption-disable-bug branch June 6, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Disabled select option can be selected with enter
4 participants