Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add stats-gl component #203

Merged
merged 3 commits into from
Sep 21, 2023

Conversation

notarun
Copy link
Contributor

@notarun notarun commented Sep 6, 2023

Closes #197
Still need to add docs I guess 😅

@netlify
Copy link

netlify bot commented Sep 6, 2023

Deploy Preview for cientos-tresjs ready!

Name Link
🔨 Latest commit 201faac
🔍 Latest deploy log https://app.netlify.com/sites/cientos-tresjs/deploys/650af02d603d540008da1d7c
😎 Deploy Preview https://deploy-preview-203--cientos-tresjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@notarun notarun changed the title feat: add stats-gl component WIP feat: add stats-gl component Sep 6, 2023
@notarun notarun changed the title WIP feat: add stats-gl component feat: add stats-gl component Sep 6, 2023
@JaimeTorrealba
Copy link
Member

Seems everything fine :)

I'll wait for the docs

@notarun
Copy link
Contributor Author

notarun commented Sep 11, 2023

I'll wait for the docs

Sure, will add sometime soon. Do you think camera-controls and stats-gl should be moved to peer dependencies?

@JaimeTorrealba
Copy link
Member

@alvarosabu Can you help me here? Would be a good idea to move them to peer dependencies?

@alvarosabu
Copy link
Member

@notarun @JaimeTorrealba what is the difference between stats.js and stats-gl?

@JaimeTorrealba
Copy link
Member

@alvarosabu stats-gl is a new fancy monitor, with more capabilities than stats.js

https://github.com/RenaudRohlinger/stats-gl

It was adopted by R3F and people like it

@alvarosabu
Copy link
Member

That being said, make sense to have both @JaimeTorrealba ?

@JaimeTorrealba
Copy link
Member

I would say yes @alvarosabu, more option to the user is always better

We could think better in the final bundle-size if that's the problem, move to peer-deps (but with clear communication to the users, to avoid the useTweakpane issue)

@notarun
Copy link
Contributor Author

notarun commented Sep 20, 2023

@JaimeTorrealba added docs and playground demo

@JaimeTorrealba
Copy link
Member

Hi @notarun, today I have a meeting with Alvaro about dependencies topics, after that we can continue with this one :)

Copy link
Member

@JaimeTorrealba JaimeTorrealba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work

@JaimeTorrealba JaimeTorrealba merged commit 40bd48c into Tresjs:main Sep 21, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stats-gl
3 participants