-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add stats-gl component #203
feat: add stats-gl component #203
Conversation
✅ Deploy Preview for cientos-tresjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Seems everything fine :) I'll wait for the docs |
Sure, will add sometime soon. Do you think |
@alvarosabu Can you help me here? Would be a good idea to move them to peer dependencies? |
@notarun @JaimeTorrealba what is the difference between stats.js and stats-gl? |
@alvarosabu stats-gl is a new fancy monitor, with more capabilities than stats.js https://github.com/RenaudRohlinger/stats-gl It was adopted by R3F and people like it |
That being said, make sense to have both @JaimeTorrealba ? |
I would say yes @alvarosabu, more option to the user is always better We could think better in the final bundle-size if that's the problem, move to peer-deps (but with clear communication to the users, to avoid the useTweakpane issue) |
@JaimeTorrealba added docs and playground demo |
Hi @notarun, today I have a meeting with Alvaro about dependencies topics, after that we can continue with this one :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work
Closes #197
Still need to add docs I guess 😅