Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): fix link to Tres, typos #317

Merged
merged 2 commits into from
Dec 22, 2023
Merged

Conversation

andretchen0
Copy link
Contributor

Problem

The link to "core" in the docs ...

Cientos (Spanish word for "hundreds", pronounced `/θjentos/` ) is a 
collection of useful ready-to-go helpers and components that are not 
part of the [core](...) package.

... was pointing to the Cientos guide and not to Tres. Tres is the "core".

Solution

Update the link to point to https://tresjs.org/.

(Also cleaned up a couple of typos.)

Copy link

stackblitz bot commented Dec 20, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Dec 20, 2023

Deploy Preview for cientos-tresjs ready!

Name Link
🔨 Latest commit 3d8f5c1
🔍 Latest deploy log https://app.netlify.com/sites/cientos-tresjs/deploys/65846173b3bf3600086ef444
😎 Deploy Preview https://deploy-preview-317--cientos-tresjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andretchen0 andretchen0 marked this pull request as ready for review December 20, 2023 22:47
@@ -2,7 +2,7 @@

![Cientos banner](/cientos-banner.png)

> Cientos (Spanish word for "hundreds", pronounced `/θjentos/` ) is is a collection of useful ready-to-go helpers and components that are not part of the [core](/guide/index.md) package. The name uses the word uses in spanish to multiply by 100, to refer to the potential reach of the package to hold a amazing abstractions.
> Cientos (Spanish word for "hundreds", pronounced `/θjentos/` ) is a collection of useful ready-to-go helpers and components that are not part of the [core](https://tresjs.org/) package. The name uses the word in Spanish to multiply by 100, to refer to the potential reach of the package to hold amazing abstractions.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> Cientos (Spanish word for "hundreds", pronounced `/θjentos/` ) is a collection of useful ready-to-go helpers and components that are not part of the [core](https://tresjs.org/) package. The name uses the word in Spanish to multiply by 100, to refer to the potential reach of the package to hold amazing abstractions.
> Cientos (Spanish word for "hundreds", pronounced `/θjentos/` ) is a collection of useful ready-to-go helpers and components that are not part of the [core](https://docs.tresjs.org/) package. The name uses the word in Spanish to multiply by 100, to refer to the potential reach of the package to hold amazing abstractions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Updated the link.

@alvarosabu alvarosabu merged commit c971949 into main Dec 22, 2023
6 checks passed
@andretchen0 andretchen0 mentioned this pull request Apr 6, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants