feat: add BakeShadows component #324
Conversation
|
|
✅ Deploy Preview for cientos-tresjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
@JaimeTorrealba probably because you are defining any props
There was a problem hiding this comment.
But Stats component has props, and the messages still appears
src/core/misc/BakeShadows.ts
Outdated
| renderer.value.shadowMap.needsUpdate = true | ||
| }) | ||
|
|
||
| return null |
There was a problem hiding this comment.
Remove return null. I believe this fixes the typing issue. Let me know if that doesn't fix it for you.
Fwiw, here's an example with no returned value in the Vue docs.
There was a problem hiding this comment.
Thank you so much, it was that 🙏
| cast-shadow | ||
| > | ||
| <TresBoxGeometry /> | ||
| <TresMeshStandardMaterial :color="0x00ff00" /> |
There was a problem hiding this comment.
TresMeshStandardMaterial's color prop expects a THREE.Color, so you'll have to instantiate one with new Color(...).
| :rotation-x="-Math.PI / 2" | ||
| > | ||
| <TresPlaneGeometry :args="[5, 5]" /> | ||
| <TresMeshStandardMaterial :color="0xf7f7f7" /> |
There was a problem hiding this comment.
Same as above. This should be a THREE.Color, not a number.
closes #321
How can I remove these warnings