Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): 329 Add cast-shadow/receive-shadow to 3D model #330

Merged
merged 3 commits into from
Jan 12, 2024

Conversation

JaimeTorrealba
Copy link
Member

closes #329

Copy link

stackblitz bot commented Jan 11, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Jan 11, 2024

Deploy Preview for cientos-tresjs ready!

Name Link
🔨 Latest commit dbd8b47
🔍 Latest deploy log https://app.netlify.com/sites/cientos-tresjs/deploys/65a137cb9b6c7d0008ead51a
😎 Deploy Preview https://deploy-preview-330--cientos-tresjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alvarosabu
Copy link
Member

Hi @JaimeTorrealba thanks for this PR, seems like you have some lint issues

Copy link
Member

@alvarosabu alvarosabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! @JaimeTorrealba lot of users are going to benefit from this

@JaimeTorrealba JaimeTorrealba merged commit f10476e into main Jan 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add cast-shadows props to exporter models
2 participants